Enable S3 multipart upload (in non-direct upload)#12358
Merged
landreev merged 2 commits intoIQSS:developfrom May 1, 2026
Merged
Enable S3 multipart upload (in non-direct upload)#12358landreev merged 2 commits intoIQSS:developfrom
landreev merged 2 commits intoIQSS:developfrom
Conversation
janvanmansum
changed the title
qqmyers
approved these changes
Apr 24, 2026
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
makes sense - thanks for the PR
github-project-automation
Bot
moved this from Ready for Triage
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
Wow, I was completely unaware of this! |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR re-enables multipart upload for non-direct uploads for S3-compatible storage. At some point between 6.7.1 and 6.9 the default changed from enabled to disabled. This PR explicitly enables it when creating the
S3AsyncClient. It will only be used when necessary anyway.Without this change, an upload of a file larger than 1G using a storage driver that does not support direct upload, the upload fails silently when clicking Save on the confirmation screen. So the file is uploaded to the Dataverse server, but then uploading it from there to the object store fails, without any error message to the user.
Which issue(s) this PR closes:
N/a
Special notes for your reviewer:
N/a
Suggestions on how to test this:
Perform an upload of a file larger than 1G, which will require the client to use multipart upload.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
See: doc/release-notes/12358-enable-s3-multipart-upload.md
Additional documentation:
No